[FFmpeg-devel] [PATCH 1/4] avcodec/mediacodec_wrapper: add missing <libavcodec/avcodec.h> include

Matthieu Bouron matthieu.bouron at gmail.com
Thu Jul 4 17:11:38 EEST 2019


On Thu, Jul 04, 2019 at 04:03:42PM +0200, Nicolas George wrote:
> Matthieu Bouron (12019-07-04):
> > ---
> >  libavcodec/mediacodec_wrapper.h | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/libavcodec/mediacodec_wrapper.h b/libavcodec/mediacodec_wrapper.h
> > index f0de16d669..58e5dc7d39 100644
> > --- a/libavcodec/mediacodec_wrapper.h
> > +++ b/libavcodec/mediacodec_wrapper.h
> > @@ -26,6 +26,8 @@
> >  #include <stdint.h>
> >  #include <sys/types.h>
> >  
> 
> > +#include <libavcodec/avcodec.h>
> 
> AFAIK, this is not the correct way of including one of our own headers,
> especially from the same sub-library. Just "avcodec.h".

Fixed in attached patch.
Thanks.

-- 
Matthieu B.
-------------- next part --------------
>From a18c2bb9ac6a2cc93434def1124266c92efda7ce Mon Sep 17 00:00:00 2001
From: Matthieu Bouron <matthieu.bouron at gmail.com>
Date: Mon, 29 Apr 2019 11:24:37 +0200
Subject: [PATCH 1/4] avcodec/mediacodec_wrapper: add missing "avcodec.h"
 include

---
 libavcodec/mediacodec_wrapper.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/libavcodec/mediacodec_wrapper.h b/libavcodec/mediacodec_wrapper.h
index f0de16d669..b106ff315a 100644
--- a/libavcodec/mediacodec_wrapper.h
+++ b/libavcodec/mediacodec_wrapper.h
@@ -26,6 +26,8 @@
 #include <stdint.h>
 #include <sys/types.h>
 
+#include "avcodec.h"
+
 /**
  * The following API around MediaCodec and MediaFormat is based on the
  * NDK one provided by Google since Android 5.0.
-- 
2.22.0



More information about the ffmpeg-devel mailing list