[FFmpeg-devel] [PATCH] lavfi/vf_nlmeans: Remove the pdiff_lut_scale to improve the performance

mypopy at gmail.com mypopy at gmail.com
Thu Jan 31 03:31:03 EET 2019


On Wed, Jan 30, 2019 at 10:24 PM Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
>
> 2019-01-30 11:56 GMT+01:00, Jun Zhao <mypopydev at gmail.com>:
> > Remove the pdiff_lut_scale in nlmeans
>
> This sentence is very misleading.
>
> > and this change will avoid
> > using pdiff_lut_scale in the exp table search in nlmean_slice, it's will
> > improve the performance about 12%.
>
> Please mention in the commit message that you increase
> the context size including the amount (and probably remove
> the part above that you "remove" something from the context).
>

Looks like I need to improve the commit message, will update in the V2. :)

In fact, when I try to use nlmeans for denoising  a 1080P size pictures, I found
nlmeans is really SO slow, then I profiling the code, found nlmeans_slice is the
bottleneck, this is the  to remove the pdiff_lut_scale when search the
exp() table in nlmeans_slice function.


More information about the ffmpeg-devel mailing list