[FFmpeg-devel] [PATCH]lavc/amrwbdec: Do not ignore NO_DATA frames
Carl Eugen Hoyos
ceffmpeg at gmail.com
Wed Jan 30 22:08:00 EET 2019
2019-01-30 20:33 GMT+01:00, Paul B Mahol <onemda at gmail.com>:
> On 1/30/19, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
>> 2019-01-29 22:47 GMT+01:00, Carl Eugen Hoyos <ceffmpeg at gmail.com>:
>>> Attached patch fixes decoding NO_DATA amr-wb frames.
>> Now with patch.
> Are you sure that reference decoder gives complete silence
> for such frames?
Probably not, the specification suggests "random signal" and
"a muting technique" to "gradually decrease the output level".
As said, the issue here is that current FFmpeg shortens the output
making it unusable, my patch fixes this.
> Please use memset.
The C standard apparently that memset(, 0, ) is not
required to work for float, do we require this?
The calloc function allocates space for an array of nmemb
objects, each of whose size is size. The space is initialized
to all bits zero. Note that this need not be the same as the
representation of floating-point zero...
More information about the ffmpeg-devel