[FFmpeg-devel] gdigrab: fix HIDPI support

Dilshod Mukhtarov dilshodm at gmail.com
Sun Jan 27 21:14:15 EET 2019

On 27.01.2019 22:51, Carl Eugen Hoyos wrote:
> 2019-01-27 1:45 GMT+01:00, Carl Eugen Hoyos <ceffmpeg at gmail.com>:
>> 2019-01-26 18:53 GMT+01:00, Dilshod Mukhtarov <dilshodm at gmail.com>:
>>> HI, this is the patch that fixes HIDPI support in gdigrab
>>> +    double h_dpr;   // Horizontal device pixel ratio
>>> +    double v_dpr;   // Vertical device pixel ratio
>> I would expect these to be AVRational, if this is not
>> possible, it should be explained why.
> Sorry if this was not an ideal comment, it should have been:
> All aspect ratio calculations (and all calculations related to
> aspect ratio) do not need double (or floats) but should be
> done as integer calculations. AVRational structs are often
> used, theoretically they may not be needed.
I attached new version of the patch, which uses integer arithmetics

With the best regards,

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-libavdevice-gdigrab-fix-HIDPI-support-for-window-cap.patch
Type: text/x-patch
Size: 2040 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190127/ecffa7e7/attachment.bin>

More information about the ffmpeg-devel mailing list