[FFmpeg-devel] gdigrab: fix HIDPI support
dilshodm at gmail.com
Sun Jan 27 20:40:31 EET 2019
Thanks for advices. I split the patch to two distinct parts. The first
part is here and the next one in a new message.
On 27.01.2019 4:45, Carl Eugen Hoyos wrote:
> 2019-01-26 18:53 GMT+01:00, Dilshod Mukhtarov <dilshodm at gmail.com>:
>> HI, this is the patch that fixes HIDPI support in gdigrab
>> + double h_dpr; // Horizontal device pixel ratio
>> + double v_dpr; // Vertical device pixel ratio
> I would expect these to be AVRational, if this is not
> possible, it should be explained why.
> Please put "else" on the same line as "}", no linebreak
> between "}" and "else".
>> 1) Mouse position was not calculated properly in area or window mode
>> 2) In window mode the size of window was not calculated properly (cropped)
> This may not apply here, but typically, if a patch says "fixes A and B",
> it should be split in two patches to ease review and future debugging.
> Carl Eugen
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
With the best regards,
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 2691 bytes
Desc: not available
More information about the ffmpeg-devel