[FFmpeg-devel] [PATCH] avfilter/acrossfade: allow skipping fade on inputs

Gyan ffmpeg at gyani.pro
Thu Jan 24 18:41:08 EET 2019



On 24-01-2019 02:22 PM, Gyan wrote:
>
>
> On 23-01-2019 11:49 PM, Paul B Mahol wrote:
>> On 1/23/19, Gyan <ffmpeg at gyani.pro> wrote:
>>>
>>> On 23-01-2019 07:40 PM, Paul B Mahol wrote:
>>>> On 1/23/19, Gyan <ffmpeg at gyani.pro> wrote:
>>>>> On 23-01-2019 03:00 PM, Paul B Mahol wrote:
>>>>>> On 1/23/19, Gyan <ffmpeg at gyani.pro> wrote:
>>>>>> Why? afade needs change too.
>>>>> If a user doesn't want to apply fade, then they can simply not add 
>>>>> afade
>>>>> filter. This change is meant for users who want to combine two audio
>>>>> streams with overlap but don't want to apply fade to audio during
>>>>> overlap.
>>>>>
>>>> I do not like such reasoning, also you changed afade too with this
>>>> approach.
>>> That was to prevent an integer value of nb_curves-1 from being 
>>> accepted.
>>>
>>> Anyway, revised patch attached, although I don't see how afade=c=nofade
>>>     is useful.
>> With previous patch it was hidden.
>>
>>> Gyan
>>>
>> Probably ok.
>
> Plan to push tonight.
>
Pushed as 3224d6691cdc59ef0d31cdb35efac27494ff515b.

Gyan


More information about the ffmpeg-devel mailing list