[FFmpeg-devel] [PATCH] avcodec: add ARBC decoder

Paul B Mahol onemda at gmail.com
Tue Jan 22 16:57:30 EET 2019


On 1/22/19, Jean-Baptiste Kempf <jb at videolan.org> wrote:
> On Tue, 22 Jan 2019, at 10:55, Paul B Mahol wrote:
>> Signed-off-by: Paul B Mahol <onemda at gmail.com>
>
> Overall, this is more readable that the ones in the past. Really cool.

With that terms: "more readable" actually means "less complex"

>
>> +        for (int j = start_y; j < end_y; j++) {
>> +            for (int k = start_x; k < end_x; k++) {
>> +                if (mask & 0x8000) {
>
> Do we know where this value comes from?
>

Can't you see? It is obvious. It reads bits from top to bottom of 16
bit number and than does something - filling blocks.


More information about the ffmpeg-devel mailing list