[FFmpeg-devel] [PATCHv2 4/4] avformat/concatdec: always re-calculate start time and duration

[Nicolas George]

Marton Balint (12019-01-04):
> Agreed, and this is how it should work even after the patch. user_duration
> which is the duration specified in the ffconcat file always have priority
> because get_best_effort_duration always considers that first. So it does not
> matter that we assign ConcatFile->duration again and again, because we will
> just reassing the same value.
> 
> Given that, I don't think an inconsitent state is possible because seeking
> is only allowed if the durations are known (if they are all set in the
> ffconcat file). On the other hand, if generic seeking is not allowed, then
> start_time will never be invalid because we always recalculate it for the
> next file when we open it.
> 
> Does this relax your concern?

I think it does. Sorry for forgetting to reply to this. Please go ahead
when convenient.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190121/844160a8/attachment.sig>