[FFmpeg-devel] [PATCH 1/2] tools/target_dec_fate.sh: print some statistics

Carl Eugen Hoyos ceffmpeg at gmail.com
Fri Jan 18 13:48:45 EET 2019


2019-01-17 22:21 GMT+01:00, Michael Niedermayer <michael at niedermayer.cc>:
> On Tue, Jan 15, 2019 at 11:41:22PM +0100, Carl Eugen Hoyos wrote:
>> 2019-01-15 23:36 GMT+01:00, Michael Niedermayer <michael at niedermayer.cc>:
>> > On Fri, Jan 04, 2019 at 08:29:36PM +0100, Michael Niedermayer wrote:
>> >> On Sat, Dec 29, 2018 at 10:47:16AM +0100, Moritz Barsnick wrote:
>> >> > On Sat, Dec 29, 2018 at 02:35:18 +0100, Michael Niedermayer wrote:
>> >> > > +        CACHED=$((CACHED+1))
>> >> >
>> >> > I believe this is the sort of math that won't work on old, non-POSIX
>> >> > Bourne shells. (I'm thinking Solaris /bin/sh here.) In case that
>> >> > even matters.
>> >>
>> >> which platform without a posix /bin/sh supports the libfuzz stuff ?
>> >
>> > ping, is there any suggestion for improving this patch ?
>> > or are all concerns resolved ?
>>
>> I believe adding more things that will not work on sunos is not
>> ideal.
>> But if there is no other way solving the issues that this patch
>> fixes, sunos is of course no show-stopper.
>
> how can i test easily that a change work with such a non posix shell ?

That is exactly what I don't know: Even on sunos it appears to
depend on settings that I don't understand.

Sorry, Carl Eugen


More information about the ffmpeg-devel mailing list