[FFmpeg-devel] [FFmpeg-cvslog] lavc/qsvenc: add VDENC support for H264

[Carl Eugen Hoyos]

2019-01-16 7:44 GMT+01:00, Li, Zhong <zhong.li at intel.com>:
>> > Is it a possible way to show "not supported" info and set the option
>> > to default off instead of  just hiding the option?
>> >
>> > Like:
>> > #if QSV_HAVE_VDENC
>> >     { "low_power", "enable low power mode (experimental, many
>> > limitations by mfx version, HW platform, BRC modes, etc.)",
>> > OFFSET(qsv.low_power), AV_OPT_TYPE_BOOL, { .i64 =  0 }, 0, 1, VE}, #
>> > else
>> >     { "low_power", "not supported", OFFSET(qsv.low_power),
>> > AV_OPT_TYPE_BOOL, { .i64 =  0 }, 0, 0, VE}, #endif
>>
>> This is also an option but I wonder if a failure message wouldn't help
>> users
>> even more.
>
> It give a remind to user to prevent to set an useless option, instead of
> setting it and expect it will take effect.

This is what I suggest with the error message.

I found your new patch after having this discussion a little disturbing.

Carl Eugen