[FFmpeg-devel] [PATCH v2] Improved the performance of 1 decode + N filter graphs and adaptive bitrate.

[Marton Balint]

On Tue, 15 Jan 2019, Carl Eugen Hoyos wrote:

> 2019-01-15 14:43 GMT+01:00, Rostislav Pehlivanov <atomnuker at gmail.com>:
>> On Tue, 15 Jan 2019 at 11:57, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
>>
>>> 2019-01-15 11:30 GMT+01:00, Rostislav Pehlivanov <atomnuker at gmail.com>:
>>> > On Tue, 15 Jan 2019 at 09:24, Shaofei Wang <shaofei.wang at intel.com>
>>> wrote:
>>>
>>> >> +#if HAVE_THREADS
>>> >> +        if (!abr_pipeline) {
>>> >> +            ret = reap_filters(1);
>>> >> +        } else {
>>> >> +            ret = pipeline_reap_filters(1, ifilter);
>>> >> +        }
>>> >>
>>> >
>>> > Same.
>>>
>>> This hunk should have brackets, it simplifies
>>> debugging and future patches at very little cost.
>>>
>>
>> No, it does not. It wastes a line.
>
> Yes, it "wastes" a line.
> But the advantage far outweighs the incredible costs.

Not that I care too much, but I would write this:

ret = abr_pipeline ? pipeline_reap_filters(1, ifilter) : reap_filters(1);

Regards,
Marton