[FFmpeg-devel] [PATCH] checkasm/af_afir: relax the max allowed absolute difference

Derek Buitenhuis derek.buitenhuis at gmail.com
Fri Jan 11 17:17:18 EET 2019

On 11/01/2019 13:28, Hendrik Leppkes wrote:
> Because the computation accumulates more inaccuarcy then FLT_EPSILON
> allows for. That value is really not of that great use. If you have
> two accurate numbers and do one calculation, it may work, but if you
> do a whole bunch of them, the error accumulates and eventually gets
> bigger then FLT_EPSILON.
> x86_32 floating point is for $reasons a tad bit less accurate then on
> x86_64, for example, resulting in the test failing. We have some other
> float tests that  do (or used to) fail sporadically due to inaccuracy
> problems, which sometimes where fixed by similar means - or
> multiplifying FLT_EPSILON to make it bigger.


Two things:

    1. That should be in the commit messages.
    2. Would some multiple of FLT_EPSILON make more sense?

- Derek

More information about the ffmpeg-devel mailing list