[FFmpeg-devel] [PATCH] checkasm/af_afir: relax the max allowed absolute difference

Derek Buitenhuis derek.buitenhuis at gmail.com
Fri Jan 11 15:12:48 EET 2019

On 10/01/2019 23:34, James Almer wrote:
> -        if (!float_near_abs_eps(cdst[i], odst[i], FLT_EPSILON)) {
> +        if (!float_near_abs_eps(cdst[i], odst[i], 6.2e-05)) {

Can you elaborate a bit more on this? FLT_EPSILON is used correctly here
as far as I can tell, and it is not clear why it fails on x86_32, and why
we should choose an arbitrary unportable number instead (who knows if it
explodes on weird systems).

- Derek

More information about the ffmpeg-devel mailing list