[FFmpeg-devel] [PATCH] avformat/http: ignore the string after char '#'

Nicolas George george at nsup.org
Thu Jan 10 10:54:50 EET 2019


Liu Steven (12019-01-10):
>     How should i understand the mean β€œthe fragment part should not have arrived there in the first place.” ?
> 
>     When i use wget to get http://ffmpeg.org/helloworld/test#hello=24
>     wget -dS http://ffmpeg.org/helloworld/test#hello=24
>     the request is GET /helloworld/test
> 
>     But ffmpeg is use full URI β€œ/helloworld/test#hello=24”
>     That will forbidden by the http server in ticket: 7660.
>      
>     or just fix it in hls.c?

I think the fragment part should be removed earlier. When the URL comes
directly from the user, I believe it should be the responsibility of the
user. When it comes from the application, the responsibility of the
application. And when it comes from a protocol, by the code handling
that protocol.

Your code just ignores the fragment, but the fragment information was
there for a reason in the first place, was it not?

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190110/5ca7e308/attachment.sig>


More information about the ffmpeg-devel mailing list