[FFmpeg-devel] [PATCH V4 1/2] avutil: add ROI data struct and bump version

[Vittorio Giovara]

On Wed, Jan 2, 2019 at 6:45 PM James Almer <jamrial at gmail.com> wrote:

> On 1/2/2019 2:18 PM, Vittorio Giovara wrote:
> > On Wed, Jan 2, 2019 at 4:13 PM Vittorio Giovara <
> vittorio.giovara at gmail.com>
> > wrote:
> >
> >>
> >>
> >> On Fri, Dec 28, 2018 at 3:17 AM Guo, Yejun <yejun.guo at intel.com> wrote:
> >>
> >
> > AVRegionOfInterest {
> >  size_t top/left/right/bottom
> > }
> >
> > AVRegionOfInterestSet {
> >  int rois_nb;
> >  AVRegionOfInterest *rois;
>
> This will go south as soon as you start copying, referencing and freeing
> frames and/or frame side data.
>
> All side data types need to be a contiguous array of bytes in memory
> with no pointers.
>

Hmm you're right, but embedding an entire array is pretty bad too,
especially because it locks the struct size...
Do you have any alternative ideas for this?
-- 
Vittorio