[FFmpeg-devel] [PATCH 16/16] avcodec/eacmv: Return more specific error codes and forward error codes

[Michael Niedermayer]

On Tue, Jan 01, 2019 at 12:03:36PM +0100, Paul B Mahol wrote:
> On 12/31/18, Michael Niedermayer <michael at niedermayer.cc> wrote:
> > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > ---
> >  libavcodec/eacmv.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/libavcodec/eacmv.c b/libavcodec/eacmv.c
> > index bf4404ce42..6f39d72b88 100644
> > --- a/libavcodec/eacmv.c
> > +++ b/libavcodec/eacmv.c
> > @@ -191,12 +191,12 @@ static int cmv_decode_frame(AVCodecContext *avctx,
> >          if (ret < 0)
> >              return ret;
> >          if (size > buf_end - buf - EA_PREAMBLE_SIZE)
> > -            return -1;
> > +            return AVERROR_INVALIDDATA;
> >          buf += size;
> >      }
> >
> > -    if (av_image_check_size(s->width, s->height, 0, s->avctx))
> > -        return -1;
> > +    if ((ret = av_image_check_size(s->width, s->height, 0, s->avctx)) < 0)
> > +        return ret;
> >
> >      if ((ret = ff_get_buffer(avctx, frame, AV_GET_BUFFER_FLAG_REF)) < 0)
> >          return ret;
> > --
> > 2.20.1
> >
> 
> All changes in set are very trivial, so LGTM.

will apply

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Into a blind darkness they enter who follow after the Ignorance,
they as if into a greater darkness enter who devote themselves
to the Knowledge alone. -- Isha Upanishad
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190101/bcd7edec/attachment.sig>