[FFmpeg-devel] [PATCH 1/2] avcodec/rangecoder: Add and test ff_rac_check_termination()

[Michael Niedermayer]

On Mon, Dec 31, 2018 at 02:50:26PM -0300, James Almer wrote:
> On 12/31/2018 1:40 PM, Michael Niedermayer wrote:
> > On Sun, Dec 23, 2018 at 07:24:49PM +0100, Michael Niedermayer wrote:
> >> Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> >> ---
> >>  libavcodec/rangecoder.c       | 19 +++++++++++++++++++
> >>  libavcodec/rangecoder.h       |  9 +++++++++
> >>  libavcodec/tests/rangecoder.c |  7 +++++--
> >>  3 files changed, 33 insertions(+), 2 deletions(-)
> > 
> > will apply
> 
> Is this function called from a hot loop? If so, it may be worth making
> it inline instead, seeing how the version argument in the only cases
> it's used is a constant.

its only called per slice, so call overhead / an extra if() should
not matter



[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is what and why we do it that matters, not just one of them.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20181231/23451c20/attachment.sig>