[FFmpeg-devel] [PATCH 5/5] lavfi: addroi filter

[Moritz Barsnick]

On Wed, Feb 27, 2019 at 22:00:23 +0000, Mark Thompson wrote:
> +static const AVOption addroi_options[] = {
> +    { "top",    "Region distance from top edge of frame",
> +      OFFSET(region_str[TOP]),    AV_OPT_TYPE_STRING, { .str = "0" }, .flags = FLAGS },
> +    { "bottom", "Region distance from bottom edge of frame",
> +      OFFSET(region_str[BOTTOM]), AV_OPT_TYPE_STRING, { .str = "0" }, .flags = FLAGS },
> +    { "left",   "Region distance from left edge of frame",
> +      OFFSET(region_str[LEFT]),   AV_OPT_TYPE_STRING, { .str = "0" }, .flags = FLAGS },
> +    { "right",  "Region distance from right edge of frame",
> +      OFFSET(region_str[RIGHT]),  AV_OPT_TYPE_STRING, { .str = "0" }, .flags = FLAGS },

My comment may not apply here, but I sometimes wish all rectangle
defining filters had compatible options.

I.e. drawbox and crop and delogo (which I use interchangably - e.g.
first the one to visually determine the other's dimensions) aren't
compatible with respect to order of unnamed options, and to names of
variables in their expression (w, iw, ow, ...).

Can ROIs not also be defined as x, y, w, h?

Moritz