[FFmpeg-devel] [PATCH v2] lavf/jacosubdec: compute subtitle duration correctly

[Michael Niedermayer]

On Tue, Feb 19, 2019 at 10:29:40AM +0100, Paul B Mahol wrote:
> On 2/19/19, Adam Sampson <ats at offog.org> wrote:
> > When a JACOsub subtitle has two timestamps, they represent its start and
> > end times (http://unicorn.us.com/jacosub/jscripts.html#l_times); the
> > duration is the difference between the two, not the sum of the two.
> >
> > The subtitle end times in the FATE test for this were wrong as a result;
> > fix them too. (This test is based on JACOsub's demo.txt, and the end
> > time computed for the last line using @ now matches what the comments
> > there say it should be.)
> >
> > Also tested in practice using MPV, a LaserDisc, and some authentic 1993
> > JACOsub files.
> >
> > Signed-off-by: Adam Sampson <ats at offog.org>
> > ---
> > v2: update the test data too (thanks, Carl Eugen!)
> >
> >  libavformat/jacosubdec.c   |  2 +-
> >  tests/ref/fate/sub-jacosub | 22 +++++++++++-----------
> >  2 files changed, 12 insertions(+), 12 deletions(-)
> >
> 
> LGTM

will apply

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you drop bombs on a foreign country and kill a hundred thousand
innocent people, expect your government to call the consequence
"unprovoked inhuman terrorist attacks" and use it to justify dropping
more bombs and killing more people. The technology changed, the idea is old.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190220/d6eec49d/attachment.sig>