[FFmpeg-devel] [PATCH 2/2] avformat/dashenc: Added comments

[Carl Eugen Hoyos]

2019-02-19 7:48 GMT+01:00, Karthick J <kjeyapal at akamai.com>:

> +    // Explanation for why certain movflags are used for streaming:

I don't think this is a useful line.

> +    // frag_every_frame :- Every frame should be moof fragment, so

Is there a smiley in the middle of the line?

> +    //     the data from current frame can be streamed without
> +    //     waiting for the completion of the entire segment.

frag_every_frame: Allows lower latency (iiuc!)
In any case, this is too long.

> +    // skip_sidx :- The SIDX atom for each moof will result in a
> +    //     significant bitrate overhead. Hence disabling it here.

skip_sidx: Reduce bitrate overhead

> +    // skip_trailer

skip_trailer: Reduce memory footprint

Carl Eugen