[FFmpeg-devel] [PATCH]lavf/spdifenc: Use a more flexible buffer model for TrueHD/MAT

[Carl Eugen Hoyos]

2019-02-15 0:23 GMT+01:00, Hendrik Leppkes <h.leppkes at gmail.com>:
> On Thu, Feb 14, 2019 at 8:11 PM Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
>>
>> Hi!
>>
>> I created attached patch with a lot of help from Hendrik, fixes ticket
>> #7731.
>>
>
> Som general comments, since I can't replay inline in this mail client:
>
> - The pseudo-timestamps are unsigned 16-bit, personally I would make
> all types that reference them uint16_t and rely on unsigned overflow
> behavior, which is fully valid and specified - no need to handle
> negatives manually, etc.

I had already changed this (only for the actual timestamp difference),
thank you!

> - The distance between frames can be incredibly large in some streams,
> I've seen it be larger then one whole MAT frame, and the output works
> reliably (MAT start/middle/end codes need to be placed within the
> padding space, of course).

That is not supported yet, could you provide such a problematic sample?
(Including the output if possible)

New patch attached, Carl Eugen
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-lavf-spdifenc-Use-a-more-flexible-buffer-model-for-T.patch
Type: text/x-patch
Size: 9742 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190215/ea227410/attachment.bin>