[FFmpeg-devel] [PATCH]lavf/img2dec: Split img2 and img2pipe options

[Carl Eugen Hoyos]

2019-02-10 18:44 GMT+01:00, Michael Niedermayer <michaelni at gmx.at>:
> On Sat, Feb 09, 2019 at 01:58:06PM +0100, Carl Eugen Hoyos wrote:
>> Hi!
>>
>> Currently if the "loop" option gets specified for -f image2pipe, there is
>> no indication for the user that the option will not work, patch attached.
>>
>> Please comment, Carl Eugen
>
>>  img2dec.c |   33 ++++++++++++++++++++-------------
>>  1 file changed, 20 insertions(+), 13 deletions(-)
>> eb41db12f922fc0780a808df6d8f832620ef9d65
>> 0001-lavf-img2dec-Split-img2-and-img2pipe-options.patch
>> From 21b11da9af5166e4bda7398a471a1e1a49352ac3 Mon Sep 17 00:00:00 2001
>> From: Carl Eugen Hoyos <ceffmpeg at gmail.com>
>> Date: Sat, 9 Feb 2019 13:49:51 +0100
>> Subject: [PATCH] lavf/img2dec: Split img2 and img2pipe options.
>>
>> ---
>>  libavformat/img2dec.c |   33 ++++++++++++++++++++-------------
>>  1 file changed, 20 insertions(+), 13 deletions(-)
>
> this breaks -loop
>
> ./ffmpeg -loop 1 -i ~/fatesamples/png1/lena-rgb24.png -t 1 test.avi

I moved the option that is obviously needed for the auto-detecting demuxers.

The original issue was that the image2pipe demuxer happily accepts
"loop" but ignores it - confusing users, I wonder if the only solution is
to split the options between image2pipe and the auto-detecting
demuxers or if there is another solution (or if both patches should
be reverted).

Sorry, Carl Eugen