[FFmpeg-devel] [PATCH]lavf/mpegts: Do not print the character coding as part of service name

[Carl Eugen Hoyos]

2019-02-07 21:40 GMT+01:00, Marton Balint <cus at passwd.hu>:
>
>
> On Thu, 7 Feb 2019, Carl Eugen Hoyos wrote:
>
>> 2019-02-07 16:34 GMT+01:00, Moritz Barsnick <barsnick at gmx.net>:
>>> On Thu, Feb 07, 2019 at 14:40:40 +0100, Carl Eugen Hoyos wrote:
>>>> +    if (p[0] < 0x20) {
>>>> +        p++;
>>>> +        if (--len < 0)
>>>> +            return NULL;
>>>> +    }
>>>
>>> If I understand section "A.2 Selection of character table" of ETSI EN
>>> 300 468 correctly, you need to drop an additional byte if the first
>>> byte (p[0]) is 0x1F, or an additional two bytes if the first one is
>>> 0x10.
>>
>> New patch attached.
>
> Don't simply drop charset information.

> You should convert the strings to UTF-8 based on that.

(Yes we should)
Do you have a sample that needs this?
If not, a patch that fixes a user-reported issue would rot
because a better (unneeded) fix is possible.

Carl Eugen