[FFmpeg-devel] [PATCH] mpeg12enc: Use Closed Captions if available

[Devin Heitmueller]

> On Feb 7, 2019, at 1:22 PM, Mathieu Duponchelle <mathieu at centricular.com> wrote:
> 
> 
> 
> On 2/7/19 7:21 PM, Devin Heitmueller wrote:
>> Isn’t this calculation incorrect?  The max cc_count possible is 31 (0x1F), hence the max size should be 93.
>> 
> 
> True that, updating

Not to nitpick, but it might also be worthwhile to create some #define such as MAX_CC_COUNT and have the comparison be "MAX_CC_COUNT * 3”.  That makes clear where the magic value “91” came from, and the compiler will optimize out the multiply anyway since it’s a constant.

Devin

---
Devin Heitmueller - LTN Global Communications
dheitmueller at ltnglobal.com


> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel