[FFmpeg-devel] [PATCH] avformat/movenc: Add more error checking when writing sample entries.

[Baptiste Coudurier]

Hi Nikolas,

> On Feb 4, 2019, at 5:02 PM, Nikolas Bowe <nbowe-at-google.com at ffmpeg.org> wrote:
> 
> Fixes a problem where a sample entry which cannot be written correctly appears to succeed, but produces an invalid file.
> For example, this command:
> ffmpeg -f lavfi -i sine=frequency=1000:duration=5 -codec:a ac3 -movflags +empty_moov -frag_duration 5000000 /tmp/foo.mp4
> produced a file with the ac-3 sample entry, but no AC3SpecificBox (dac3) child, which is invalid according to ETSI TS 102 366.

Ideally I feel that the code you fail as early as possible, so ideally fail during “mov_write_header” if the issue is extradata related.

[…]

— 
Baptiste