[FFmpeg-devel] [PATCH] avformat/mov: fix sidx size being doubled in offset.

John Stebbins jstebbins at jetheaddev.com
Fri Feb 1 21:12:24 EET 2019


On 1/30/19 1:18 PM, Carl Eugen Hoyos wrote:
> 2019-01-30 19:44 GMT+01:00, no pls <agrecascino123 at gmail.com>:
>> From: mptcultist <agrecascino123 at gmail.com>
>>
>> fixes an issue where if the video size was very specific,
>> ffmpeg would hang from not filling the sidx_pts for all
>> streams, due to not reading the last sidx lump. for #7572
> Please wait for a review from John who has promised to look at
> this issue "on Wednesday".
>
> Carl Eugen


Sorry I haven't had time to devote to this yet.

This patch is incorrect however.  offsets are relative to the anchor 
point which is the *end* of the sidx. See ISO 14496-12 section 8.16.3.

"In the file containing the Segment Index box, the anchor point for a 
Segment Index box is the first byte after that box."



More information about the ffmpeg-devel mailing list