[FFmpeg-devel] [PATCH 4/4] avcodec/libx265: disable openGOP by default

[James Almer]

On 12/30/2019 9:39 PM, Derek Buitenhuis wrote:
> On 30/12/2019 23:50, James Almer wrote:
>> No, it doesn't. The libx264 wrapper disables openGOP by default (by
>> doing the same thing as this patch). Or at least it does now. No idea
>> back then.
> 
> It seems to have gone back and forth over the years...

OpenGOP in libx264 was set to disabled by default in
a716006a7d6371a8f124be49d7ce59bcc28f9e53, seven years ago, and it hasn't
been changed since.

> 
>> My objective is having both encoder wrappers behave as similar as
>> possible (Sort of like vpx and aom). If i for example wanted to set
>> strict GOPs for a dash scenario with fixed segment durations, with
>> libx264 i only need to set keyint_min and keyint_max to some value using
>> the global options, but with libx265 I'd have to do that and also
>> disable openGOP.
> 
> Seems reasonable.

Up to you. It's a change in default behavior, so nothing critical.
Also, maybe it needs a micro bump?

> 
> - Derek
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>