[FFmpeg-devel] [PATCH 2/3] avcodec/libx265: add a qp option and apply the relevant global AVCodecContext settings to the encoder context

[James Almer]

On 12/29/2019 8:53 AM, Michael Niedermayer wrote:
> On Sat, Dec 28, 2019 at 08:55:13PM -0300, James Almer wrote:
>> Signed-off-by: James Almer <jamrial at gmail.com>
>> ---
>>  doc/encoders.texi    | 22 ++++++++++++++++++++++
>>  libavcodec/libx265.c | 28 ++++++++++++++++++++++++++++
>>  2 files changed, 50 insertions(+)
> 
> breaks build here, i susupect missing libx265 version check ...
> 
> CC	libavcodec/libx265.o
> libavcodec/libx265.c: In function ‘libx265_encode_init’:
> libavcodec/libx265.c:237:24: error: ‘struct <anonymous>’ has no member named ‘qpMin’
>          ctx->params->rc.qpMin = avctx->qmin;
>                         ^
> libavcodec/libx265.c:239:24: error: ‘struct <anonymous>’ has no member named ‘qpMax’
>          ctx->params->rc.qpMax = avctx->qmax;
>                         ^
> libavcodec/libx265.c:241:20: error: request for member ‘rc’ in something not a structure or union
>          ctx->params.rc.qpStep = avctx->max_qdiff;
>                     ^

Is this a distro provided libx265? The commit that added these fields is
three and a half years old by now.

I'm inclined to bump the required library version from 68 to 89, to
reduce clutter from pre-processor checks. But i want to hear Derek's
opinion first since he's the maintainer.