[FFmpeg-devel] [PATCH] lavfi: add mbfequalizer filter.

James Almer jamrial at gmail.com
Mon Dec 23 15:38:41 EET 2019


On 12/23/2019 10:25 AM, Nicolas George wrote:
> Thanks for the comment.
> 
> James Almer (12019-12-23):
>>> +        frame_out = ff_get_audio_buffer(ctx->outputs[0], frame->nb_samples);
> 
>> Can't you use av_frame_make_writable() instead to simplify this?
> 
> No, because it does not use ff_get_audio_buffer(), and therefore does
> not allow direct rendering. Also, it unnecessarily copies the data. I
> have already noted that this is a frequent pattern in filters that
> should be factored soon.
> 
> Regards,

I see, thanks for the clarification.

> 
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
> 



More information about the ffmpeg-devel mailing list