[FFmpeg-devel] [PATCH v2 2/2] avcodec/libvpxenc: add a way to explicitly set temporal layer id

Wonkap Jang wonkap at google.com
Thu Dec 19 02:59:06 EET 2019


Hi Michael,

On Wed, Dec 18, 2019 at 2:59 PM Michael Niedermayer <michael at niedermayer.cc>
wrote:

> On Tue, Dec 17, 2019 at 02:42:21PM -0800, Wonkap Jang wrote:
> > In order for rate control to correctly allocate bitrate to each temporal
> > layer, correct temporal layer id has to be set to each frame. This
> > commit provides the ability to set correct temporal layer id for each
> > frame.
> > ---
> >  libavcodec/libvpxenc.c | 11 ++++++++++-
> >  1 file changed, 10 insertions(+), 1 deletion(-)
>
> these 2 patches together fail to build
>
> CC      libavcodec/libvpxenc.o
> libavcodec/libvpxenc.c: In function ‘vpx_encode’:
> libavcodec/libvpxenc.c:1541:25: error: ‘vpx_svc_layer_id_t’ has no member
> named ‘temporal_layer_id_per_spatial’
>                  layer_id.temporal_layer_id_per_spatial[0] =
> layer_id.temporal_layer_id;
>                          ^
> libavcodec/libvpxenc.c:1572:17: error: ‘vpx_svc_layer_id_t’ has no member
> named ‘temporal_layer_id_per_spatial’
>          layer_id.temporal_layer_id_per_spatial[0] =
> layer_id.temporal_layer_id;
>                  ^
> make: *** [libavcodec/libvpxenc.o] Error 1
>
> Looks like I missed guarding it with version number. I'll make the change.

Thanks,

Wonkap


> [...]
>
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Freedom in capitalist society always remains about the same as it was in
> ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".


More information about the ffmpeg-devel mailing list