[FFmpeg-devel] [PATCH 1/5] fftools/ffmpeg: Fix forward CPB props in to out

[Hendrik Leppkes]

On Mon, Dec 16, 2019 at 6:39 PM Nicolas Gaullier
<nicolas.gaullier at cji.paris> wrote:
>
> ---
>  fftools/ffmpeg.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
> index 27f68933f8..36c207653b 100644
> --- a/fftools/ffmpeg.c
> +++ b/fftools/ffmpeg.c
> @@ -3562,12 +3562,14 @@ static int init_output_stream(OutputStream *ost, char *error, int error_len)
>              int i;
>              for (i = 0; i < ist->st->nb_side_data; i++) {
>                  AVPacketSideData *sd = &ist->st->side_data[i];
> +                if (sd->type != AV_PKT_DATA_CPB_PROPERTIES) {
>                  uint8_t *dst = av_stream_new_side_data(ost->st, sd->type, sd->size);
>                  if (!dst)
>                      return AVERROR(ENOMEM);
>                  memcpy(dst, sd->data, sd->size);
>                  if (ist->autorotate && sd->type == AV_PKT_DATA_DISPLAYMATRIX)
>                      av_display_rotation_set((uint32_t *)dst, 0);
> +                }
>              }
>          }
>

Can you clarify why you are exlcuding CBP side-data from being copied
here? It seems to not match the commit message in my mind.
Note that from some containers, namely mov/mp4, the container can
actually provide CBP data, which means the stream CBP data would be
valid and potentially relevant.

- Hendrik