[FFmpeg-devel] [PATCH, v2] FATE: add test for hevc files with 4 TUDepth(0..4) of cbf_cb/cbf_cr

[James Almer]

On 12/13/2019 4:05 AM, Fu, Linjie wrote:
>> -----Original Message-----
>> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of
>> Carl Eugen Hoyos
>> Sent: Friday, December 13, 2019 10:47
>> To: FFmpeg development discussions and patches <ffmpeg-
>> devel at ffmpeg.org>
>> Subject: Re: [FFmpeg-devel] [PATCH, v2] FATE: add test for hevc files with 4
>> TUDepth(0..4) of cbf_cb/cbf_cr
>>
>> Am Fr., 13. Dez. 2019 um 03:43 Uhr schrieb Linjie Fu <linjie.fu at intel.com>:
>>
>>> 5 cabac states for cbf_cb and cbf_cr are supported according to
>>> Table 9-4.
>>>
>>> Add a test for 64x64 4:4:4 8bit HEVC clips with TUDepth = 4, cbf_cr > 0.
>>> +fate-hevc-cabac-tudepth: CMD = framecrc -flags unaligned -i
>> $(TARGET_SAMPLES)/hevc/hevc-cabac-tudepth.hevc -pix_fmt yuv444p
>>
>> File name looks wrong to me...
>>
> I renamed the clips to *.hevc and try to be consistent with other files in fate/hevc/.
> 
> (If it's not strictly required, cbf_cr_cb_TUDepth_4_circle.h265 may be more straight
> forward and it has already been in fate-suite)

That's the name the sample has in the fate-suite already, so no reason
to change it. Especially if it's the better name.

> 
> -fate-hevc-cabac-tudepth: CMD = framecrc -flags unaligned -i $(TARGET_SAMPLES)/hevc/hevc-cabac-tudepth.hevc -pix_fmt yuv444p
> +fate-hevc-cabac-tudepth: CMD = framecrc -flags unaligned -i $(TARGET_SAMPLES)/hevc/cbf_cr_cb_TUDepth_4_circle.h265 -pix_fmt yuv444p
> 
> Do I need to update this in a new version(v3)?

Yes, please.

> 
> - linjie
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>