[FFmpeg-devel] [PATCH V2 1/2] lavf/libsrt: add linger parameter to libsrt

Andriy Gelman andriy.gelman at gmail.com
Mon Dec 2 15:30:45 EET 2019


On Mon, 02. Dec 14:25, mypopy at gmail.com wrote:
> On Mon, Dec 2, 2019 at 12:57 PM Andriy Gelman <andriy.gelman at gmail.com>
> wrote:
> >
> > On Sun, 01. Dec 21:31, Jun Zhao wrote:
> > > From: Jun Zhao <barryjzhao at tencent.com>
> > >
> > > add linger parameter to libsrt, it's setting he number of seconds
> > > that the socket waits for unsent data when closing.
> >
> > minor spelling
> >
> Will fix
> > >
> > > Signed-off-by: Jun Zhao <barryjzhao at tencent.com>
> > > ---
> > >  doc/protocols.texi   |    4 ++++
> > >  libavformat/libsrt.c |   13 +++++++++++++
> > >  2 files changed, 17 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/doc/protocols.texi b/doc/protocols.texi
> > > index 0e18a49..f34f246 100644
> > > --- a/doc/protocols.texi
> > > +++ b/doc/protocols.texi
> > > @@ -1426,6 +1426,10 @@ the overhead transmission (retransmitted and
> control packets).
> > >  file: Set options as for non-live transmission. See @option{messageapi}
> > >  for further explanations
> > >
> >

> > > + at item linger=@var{seconds}
> > > +The number of seconds that the socket waits for unsent data when
> closing.
> > > +Default is -1.
> >
> > I'd add infinite in brackets.
> Can't get your point, more details?

It would be good to add what -1 means here.

I initially thought it's an infinite wait but from the srt docs it looks that
SRTO_LINGER defaults to on/180 seconds.

> > Are some other parameters (latency, rcvlatency, connect_timeout) in
> milliseconds? (It's not that clear from the docs).
> > If yes, it may be good to set linger to milliseconds as well.
> >
> The SRT docs (https://github.com/Haivision/srt/blob/master/docs/API.md)
> used the seconds,  and I think SRT borrow the option from socket SO_LINGER
> (http://man7.org/linux/man-pages/man7/socket.7.html), we can keep the
> similar semantics with seconds.

ok

-- 
Andriy


More information about the ffmpeg-devel mailing list