[FFmpeg-devel] [PATCH] avformat/mpegts: fix teletext PTS when selecting teletext streams only

Marton Balint cus at passwd.hu
Sat Aug 31 19:22:53 EEST 2019



On Wed, 28 Aug 2019, Jan Ekström wrote:

> On Sat, Aug 24, 2019 at 2:04 AM Marton Balint <cus at passwd.hu> wrote:
>>
>> After a1b4f120c031e6697bac9fd8c725d9c37ee36d13 the teletext PTS values were set
>> to AV_NOPTS_VALUE if the stream of the PCR pid was discarded.
>>
>> What actually matters is that if we parse the PCR of the PCR PID or not, so
>> let's use the cached discard value of the actual PCR PID instead of the stream
>> discard value, which may be different.
>>
>> Also fixes ticket #7567, which was caused by the fact that teletext PTS values
>> were not touched if the PCR pid was discarded even before
>> a1b4f120c031e6697bac9fd8c725d9c37ee36d13.
>>
>> Signed-off-by: Marton Balint <cus at passwd.hu>
>> ---
>
> I just hit this myself, and this seems to indeed fix the case where
> you f.ex. -map only the teletext stream with ffmpeg.c and output f.ex.
> SRT. So in that sense this seems like a sensible change.

Thanks, applied.

> Would be much obliged if someone could run this through FATE? I will
> attempt during this week to create a minimal sample so we could get a
> FATE test for this behavior :) (as this is demux-only).

Yeah, seems useful.

Regards,
Marton


More information about the ffmpeg-devel mailing list