[FFmpeg-devel] [PATCH 3/3] avformat/mov: Check for EOF in mov_read_meta()

[Nicolas George]

James Almer (12019-08-31):
> There's Marton's "avformat/utils: return pending IO error on EOF in
> av_read_frame()" patch to check in generic code if avio_feof() != 0 is
> an actual EOF or an IO error, so if you make this code here simply break
> the loop, same as it's done in mov_read_default(), then said generic
> code would be triggered and return the proper error code once the
> current packet is done processing.

Please do not do that. It would be gaining very little time and lines of
code now at the cost of a likely maintenance nightmare later. Let us
keep the logic of the code local if it can be.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190831/18633c3e/attachment.sig>