[FFmpeg-devel] [PATCH v5] Add ZeroMQ as protocol option

[Marton Balint]

On Fri, 30 Aug 2019, Andriy Gelman wrote:

> Changes in v5:
>    - Use polling in a loop to check interrupt callback.
>    - Remove timeout_send/timeout_recv options and update
>      documentation.

Thanks, two comments:

I noticed that you created a version requirement: libzmq >= 4.3.1. That is 
a bit new. Are you actually using API which is not available or broken in 
older releases? If yes, then OK. If not, then I'd relax this to 4.2.0 or 
something around that release.

The other issue I can see is that you are using function names like 
ff_zmq_*. That is a bit misleading, because in ffmpeg libraries ff_* 
functions are common functions used from multiple C files. This is 
not the case here, so please change the ff prefix of the static 
functions to something else (e.g: zmq or zmqproto to not clash with 
real zmq library function names).

Thanks,
Marton