[FFmpeg-devel] [PATCH 4/3 v2][RFC] avcodec/qtrle: call ff_reget_buffer() only when the picture data is going to change

[James Almer]

On 8/27/2019 12:51 PM, Michael Niedermayer wrote:
> On Mon, Aug 26, 2019 at 04:02:14PM -0300, James Almer wrote:
>> ff_reget_buffer() will attempt to create a writable copy of the frame,
>> which is not needed when the decoder intends to return a reference to
>> the same buffer as the previous frame.
>>
>> Should reduce data copy, hopefully achieving a similar speed up as
>> a9dacdeea6168787a142209bd19fdd74aefc9dd6 without dropping frames.
>>
>> Signed-off-by: James Almer <jamrial at gmail.com>
>> ---
>> Now ensuring there's a previous frame available to reuse.
>>
>>  libavcodec/qtrle.c | 14 ++++++++++++--
>>  1 file changed, 12 insertions(+), 2 deletions(-)
> 
> would a function like ff_reget_buffer() but that returns a read only frame
> simplify this ?

Yeah, either that, or maybe adding a new parameter to ff_reget_buffer().

> 
> Such function could then later also set any flag or UID

Frames are meant to be independent, so i don't think tying them to some
decoder instance id is a good idea, if that's what you meant in the
other thread.

> 
> either way patch LGTM

Will push, thanks.

> 
> thx
> 
> [...]
> 
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>