[FFmpeg-devel] [PATCH 1/2] avcodec/aacdec: Add FF_CODEC_CAP_INIT_CLEANUP

[Paul B Mahol]

lgtm

On Fri, Aug 23, 2019 at 12:54 AM Michael Niedermayer <michael at niedermayer.cc>
wrote:

> Fixes: memleaks
> Fixes:
> 16289/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AAC_LATM_fuzzer-5200695692623872
>
> Found-by: continuous fuzzing process
> https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> Signed-off-by
> <https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by>:
> Michael Niedermayer <michael at niedermayer.cc>
> ---
>  libavcodec/aacdec.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libavcodec/aacdec.c b/libavcodec/aacdec.c
> index c606ad40a9..98b6e58be3 100644
> --- a/libavcodec/aacdec.c
> +++ b/libavcodec/aacdec.c
> @@ -559,7 +559,7 @@ AVCodec ff_aac_decoder = {
>          AV_SAMPLE_FMT_FLTP, AV_SAMPLE_FMT_NONE
>      },
>      .capabilities    = AV_CODEC_CAP_CHANNEL_CONF | AV_CODEC_CAP_DR1,
> -    .caps_internal   = FF_CODEC_CAP_INIT_THREADSAFE,
> +    .caps_internal   = FF_CODEC_CAP_INIT_THREADSAFE |
> FF_CODEC_CAP_INIT_CLEANUP,
>      .channel_layouts = aac_channel_layout,
>      .flush = flush,
>      .priv_class      = &aac_decoder_class,
> @@ -584,7 +584,7 @@ AVCodec ff_aac_latm_decoder = {
>          AV_SAMPLE_FMT_FLTP, AV_SAMPLE_FMT_NONE
>      },
>      .capabilities    = AV_CODEC_CAP_CHANNEL_CONF | AV_CODEC_CAP_DR1,
> -    .caps_internal   = FF_CODEC_CAP_INIT_THREADSAFE,
> +    .caps_internal   = FF_CODEC_CAP_INIT_THREADSAFE |
> FF_CODEC_CAP_INIT_CLEANUP,
>      .channel_layouts = aac_channel_layout,
>      .flush = flush,
>      .profiles        = NULL_IF_CONFIG_SMALL(ff_aac_profiles),
> --
> 2.23.0
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".