[FFmpeg-devel] [PATCH 2/4] avformat/mpegtsenc: add support for setting PCR interval for VBR streams

[Marton Balint]

On Fri, 16 Aug 2019, Andreas Håkon wrote:

> Hi Marton,
>
> Very good work with your series of patches on the mpegtsenc!
>
> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> On Thursday, 15 de August de 2019 1:51, Marton Balint <cus at passwd.hu> wrote:
>
>> Also document the algorithm for the default PCR interval.
>
>> [...]
>
>> +   if (ts->mux_rate > 1 || ts->pcr_period_ms >= 0) {
>> +          int pcr_period_ms = ts->pcr_period_ms == -1 ? PCR_RETRANS_TIME : ts->pcr_period_ms;
>> +          ts_st->pcr_period = av_rescale(pcr_period_ms, PCR_TIME_BASE, 1000);
>>     } else {
>>     /* For VBR we select the highest multiple of frame duration which is less than 100 ms. */
>
> A simple aesthetic comment:
> Please, change this to...
> /* By default, for VBR we select the highest multiple of frame duration which is less than 100 ms. */

Ok, changed locally.

Will apply patchset soon.

Regards,
Marton