[FFmpeg-devel] [PATCH 1/4] avformat/realtextdec: free queue on error

Michael Niedermayer michael at niedermayer.cc
Thu Aug 22 18:58:31 EEST 2019


On Wed, Aug 21, 2019 at 08:48:25PM -0300, James Almer wrote:
> On 8/21/2019 7:18 PM, Michael Niedermayer wrote:
> > Fixes: memleak
> > Fixes: 16277/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5696629440512000
> > 
> > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > ---
> >  libavformat/realtextdec.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/libavformat/realtextdec.c b/libavformat/realtextdec.c
> > index 204e557aa2..c2316da0ed 100644
> > --- a/libavformat/realtextdec.c
> > +++ b/libavformat/realtextdec.c
> > @@ -123,6 +123,8 @@ static int realtext_read_header(AVFormatContext *s)
> >  
> >  end:
> >      av_bprint_finalize(&buf, NULL);
> > +    if (res < 0)
> > +        ff_subtitles_queue_clean(&rt->q);
> 
> LGTM

will apply

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Any man who breaks a law that conscience tells him is unjust and willingly 
accepts the penalty by staying in jail in order to arouse the conscience of 
the community on the injustice of the law is at that moment expressing the 
very highest respect for law. - Martin Luther King Jr
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190822/509bb8c8/attachment.sig>


More information about the ffmpeg-devel mailing list