[FFmpeg-devel] [PATCH] DVB EPG decoder

[Carl Eugen Hoyos]

Am Do., 22. Aug. 2019 um 12:42 Uhr schrieb Michael Niedermayer
<michael at niedermayer.cc>:
>
> On Wed, Aug 21, 2019 at 06:28:08PM +0200, Anthony Delannoy wrote:
> > Hi,
> >
> > In the attached files is the first implementation of:
> > * dvb descriptors parsing api to ease their use on different sections (for
> > now i've only implemented EIT section)
> > * EIT table and subtable
> > * EIT callback in lavf/mpegts.c generating epg AVPacket
> > * EPG decoder to decode epg AVPacket and store decoded infos in
> > AVFrame::side_data with a new type AV_FRAME_DATA_EPG_TABLE
> >
> > I kept the EPG{Sub,}Table as raw as possible, EPG data manipulation have to
> > be done using FFmpeg API for now.
> >
> > Let me know if those patch need changements/improvements.
>
> fate checksums change so this needs to update them if the changes are intended

To clarify: This should not be a 13th patch but every patch has to include
the fate changes it causes.

> fails to build on MIPS

Seems to be because of these two structs within EPGTable and EPGSubTable:
+    struct {
+        int nb_descriptors;
+        void **descriptors;
+    };

Some of your new files do not contain license headers, please fix that
independently
of other reviews.

Afaict, some patches change files that were added in earlier patches. This may
not be ideal.

Why are the big api changes necessary at all?

Carl Eugen