[FFmpeg-devel] [PATCH] cinepakenc: When rd_frame() doesn't use MC, mark pkt as keyframe and reset curframe

[Tomas Härdin]

tor 2019-08-15 klockan 14:20 -0300 skrev James Almer:
> On 8/15/2019 2:13 PM, Tomas Härdin wrote:
> > tor 2019-08-15 klockan 12:54 -0300 skrev James Almer:
> > > On 8/15/2019 11:34 AM, Tomas Härdin wrote:
> > > > 
> > > > Aside: what is -keyint_min for exactly? It seems to be used as a max in
> > > > msvideo1enc.c, but libx264.c and libxavs.c uses it and gop_size as
> > > > minimum and maximum respectively.. Feels like the relevant encoders
> > > > need to be brought into line (assuming it doesn't break user scripts)
> > > 
> > > Afaik, keyint_min is minimum interval/distance between keyframes. So
> > > yes, if it's being used as max distance then it's wrong, as that's what
> > > gop_size is for.
> > 
> > Make sense. But why is gop_size < keyint_min by default then? 12 vs 25.
> 
> I have no idea.
> 
> > I think the x264 people have complained multiple times about the
> > default gop_size setting even
> 
> The libx264 wrapper changes both to -1 in libavcodec, which means x264's
> own defaults will be used instead. So if they complained then i guess it
> was changed accordingly.

Didn't know encoders could have their own defaults. Updated patch
attached. I added some sanity checks on -keyint_min and -g as well.

I couldn't find rl's contact information, hopefully they are subscribed
to this list.

/Tomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-cinepakenc-When-rd_frame-doesn-t-use-MC-mark-pkt-as-.patch
Type: text/x-patch
Size: 7153 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190815/152d9dc7/attachment.bin>