[FFmpeg-devel] [PATCHv2 5/6] avformat/mpegtsenc: fix PCR generation intervals

Marton Balint cus at passwd.hu
Thu Aug 15 00:31:38 EEST 2019



On Mon, 12 Aug 2019, Andreas Håkon wrote:

> Hi Marton,
>
>
> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> On Sunday, 11 de August de 2019 22:14, Marton Balint <cus at passwd.hu> wrote:
>
>> > > +            /* For VBR we select the highest multiple of frame duration which is less than 100 ms. */
>> >
>> > Don't you think it's a good idea to use the parameter "pcr_period" as the limit,
>> > instead of a fixed value of 100ms?
>>
>> Yes, but I think it is better make that feature a separate patch.
>
> OK. Waiting for it.
>
>
>> > And I think you've forgotten the file "muxers.texi" in this v2 version of the patch.
>> > (the original patch 5 has it).
>>
>> That is intentional. The existing behaviour is preserved, so no change is
>> required in the docs. When I make a separate patch to add support for
>> setting pcr_period for VBR (should be trivial to do on top of the existing
>> patchset), then I will update the docs.
>
> OK. Then no problem.

I pushed this series, will post the patch which enables setting pcr period 
for VBR.

Regards,
Marton


More information about the ffmpeg-devel mailing list