[FFmpeg-devel] [PATCH] avcodec/videotoolbox_hevc: avoid leaking cached_hw_frames_ctx

Pavel Koshevoy pkoshevoy at gmail.com
Wed Aug 14 13:46:17 EEST 2019


On Tue, Aug 6, 2019 at 8:50 PM Pavel Koshevoy <pkoshevoy at gmail.com> wrote:
>
> vtctx->cached_hw_frames_ctx is unref'd in videotoolbox_uninit,
> but videotoolbox_hevc used ff_videotoolbox_uninit which
> doesn't unref cache_hw_frames_ctx.
> ---
>  libavcodec/videotoolbox.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/videotoolbox.c b/libavcodec/videotoolbox.c
> index c718e82cc5..acaeef77dd 100644
> --- a/libavcodec/videotoolbox.c
> +++ b/libavcodec/videotoolbox.c
> @@ -1143,7 +1143,7 @@ const AVHWAccel ff_hevc_videotoolbox_hwaccel = {
>      .end_frame      = videotoolbox_hevc_end_frame,
>      .frame_params   = videotoolbox_frame_params,
>      .init           = videotoolbox_common_init,
> -    .uninit         = ff_videotoolbox_uninit,
> +    .uninit         = videotoolbox_uninit,
>      .priv_data_size = sizeof(VTContext),
>  };
>
> --
> 2.16.4
>


Ping.  It's a 1-line leak fix ... is there any reason this should not
be applied?

Thank you,
    Pavel.


More information about the ffmpeg-devel mailing list