[FFmpeg-devel] [PATCH 4/8] avcodec/ffwavesynth: Fixes invalid shift with pink noise seeking

Nicolas George george at nsup.org
Mon Aug 12 23:49:56 EEST 2019


Michael Niedermayer (12019-08-10):
> Fixes: left shift of negative value -961533698048
> Fixes: 16242/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FFWAVESYNTH_fuzzer-5738550670131200
> 
> Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> ---
>  libavcodec/ffwavesynth.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

No objection for either of these patches.

But I want to be on record that I think they were a waste of time, as
these undefined behaviors have no chance of devolving into anything
except possibly garbled output on strange architectures for an obscure
format. Compilers are practical tools, not an axiomatic system.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190812/2fbefe69/attachment.sig>


More information about the ffmpeg-devel mailing list