[FFmpeg-devel] [PATCH]lavf/dump: Fix cpb bitrate types after next major bump

James Almer jamrial at gmail.com
Sat Aug 10 18:01:42 EEST 2019


On 8/10/2019 9:47 AM, Carl Eugen Hoyos wrote:
> Hi!
> 
> Attached patch fixes a compilation warning when compiling without
> FF_API_UNSANITIZED_BITRATES.
> 
> Please comment, Carl Eugen
> 
> 
> 0001-lavf-dump-Fix-cpb-bitrate-type-after-next-major-bump.patch
> 
> From 48f7c57037206fe734bd45dc12c6140220afe34f Mon Sep 17 00:00:00 2001
> From: Carl Eugen Hoyos <ceffmpeg at gmail.com>
> Date: Sat, 10 Aug 2019 14:43:58 +0200
> Subject: [PATCH] lavf/dump: Fix cpb bitrate type after next major bump.
> 
> ---
>  libavformat/dump.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/libavformat/dump.c b/libavformat/dump.c
> index 1c44656071..126641259d 100644
> --- a/libavformat/dump.c
> +++ b/libavformat/dump.c
> @@ -320,7 +320,11 @@ static void dump_cpb(void *ctx, AVPacketSideData *sd)
>      }
>  
>      av_log(ctx, AV_LOG_INFO,
> +#if FF_API_UNSANITIZED_BITRATES
>             "bitrate max/min/avg: %d/%d/%d buffer size: %d vbv_delay: %"PRId64,
> +#else
> +           "bitrate max/min/avg: %"PRIu64"/%"PRIu64"/%"PRIu64" buffer size: %d vbv_delay: %"PRId64,

They are int64_t, so PRId64. vbv_delay is what should be PRIu64.

LGTM with that fixed.

> +#endif
>             cpb->max_bitrate, cpb->min_bitrate, cpb->avg_bitrate,
>             cpb->buffer_size,
>             cpb->vbv_delay);
> -- 2.22.0


More information about the ffmpeg-devel mailing list