[FFmpeg-devel] [PATCH] tools/zmqsend: Avoid mem copy past the end of input buffer

[Paul B Mahol]

On Thu, Aug 8, 2019 at 4:44 PM Andriy Gelman <andriy.gelman at gmail.com>
wrote:

> From: Andriy Gelman <andriy.gelman at gmail.com>
>
> This patch avoids a read past the end of the input buffer in memcpy since
> the size
> of the received zmq message is recv_buf_size - 1.
> ---
>  tools/zmqsend.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/zmqsend.c b/tools/zmqsend.c
> index 7bd7fe4199..f26fa9c1c2 100644
> --- a/tools/zmqsend.c
> +++ b/tools/zmqsend.c
> @@ -155,7 +155,7 @@ int main(int argc, char **argv)
>          ret = 1;
>          goto end;
>      }
> -    memcpy(recv_buf, zmq_msg_data(&msg), recv_buf_size);
> +    memcpy(recv_buf, zmq_msg_data(&msg), recv_buf_size - 1);
>      recv_buf[recv_buf_size-1] = 0;
>      printf("%s\n", recv_buf);
>      zmq_msg_close(&msg);
> --
> 2.22.0
>
>
LGTM


> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".