[FFmpeg-devel] libavcodec: add timeshift bitstream filter [v3]

[Nicolas George]

Andreas Håkon (12019-08-08):
> > setpts or setts, similar to lavfi.

> Then I proposse these two alternatives:
> 
> 1) "editpts_bsf"
> 2) "setpts_bsf"
> 
> The "_bsf" is not real, only to differenciate (here) from other filters.
> Which one do you prefer?

editpts has no similarity with lavfi. Users would need to remember if it
is filters <-> set and bsf <-> edit or filters <-> edit and bsf <-> set.
Better have a single name.

Bitstream filters and lavfi are not in the same namespace, therefore the
suffix is unneeded.


Gyan (12019-08-08):
> This BSF only allows to apply a fixed offset whereas the setpts filter
> allows arbitrary expressions. Unless someone is planning to extend this
> BSF,  the current candidate is more apt.

At some point, somebody will implement generic expression eval. When
that happens, it will be better if they can just add an option to the
existing filter rather than creating a whole new filter, deprecating the
existing one, etc.

Key idea: long term planning.

Therefore, I am for setpts (dts is just secondary), with a mention in
the documentation:

# Unlike the setpts filter in libavfilter, this filter currently can
# only apply a constant offset.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190808/c9f6e475/attachment.sig>