[FFmpeg-devel] [PATCH v4] avutil/mips: refine msa macros CLIP_*.

[顾希伟]

> 发件人: "Michael Niedermayer" <michael at niedermayer.cc>
> 发送时间: 2019-08-08 07:05:13 (星期四)
> 收件人: "FFmpeg development discussions and patches" <ffmpeg-devel at ffmpeg.org>
> 抄送: 
> 主题: Re: [FFmpeg-devel] [PATCH v4] avutil/mips: refine msa macros CLIP_*.
> 
> On Wed, Aug 07, 2019 at 05:52:00PM +0800, gxw wrote:
> > Changing details as following:
> > 1. Remove the local variable 'out_m' in 'CLIP_SH' and store the result in
> >    source vector.
> > 2. Refine the implementation of macro 'CLIP_SH_0_255' and 'CLIP_SW_0_255'.
> >    Performance of VP8 decoding has speed up about 1.1%(from 7.03x to 7.11x).
> >    Performance of H264 decoding has speed up about 0.5%(from 4.35x to 4.37x).
> >    Performance of Theora decoding has speed up about 0.7%(from 5.79x to 5.83x).
> > 3. Remove redundant macro 'CLIP_SH/Wn_0_255_MAX_SATU' and use 'CLIP_SH/Wn_0_255'
> >    instead, because there are no difference in the effect of this two macros.
> 
> can these 3 things be split into 3 patches ?
> It would be clearer if each change would be in its own patch
> 
> thanks
> 
> [...]
> -- 
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> 
> Whats the most studid thing your enemy could do ? Blow himself up
> Whats the most studid thing you could do ? Give up your rights and
> freedom because your enemy blew himself up.

It can be split into 3 patches. But there some benefits as 1 patch, these macros belong to the same class and are highly relevant. It is more intuitive to put them in a patch.

thanks

北京市海淀区中关村环保科技示范园龙芯产业园2号楼 100095电话: +86 (10) 62546668传真: +86 (10) 62600826www.loongson.cn本邮件及其附件含有龙芯中科技术有限公司的商业秘密信息，仅限于发送给上面地址中列出的个人或群组。禁止任何其他人以任何形式使用（包括但不限于全部或部 分地泄露、复制或散发）本邮件及其附件中的信息。如果您错收本邮件，请您立即电话或邮件通知发件人并删除本邮件。 

This email and its attachments contain confidential information from Loongson
Technology Corporation Limited, which is intended only for the person or entity
whose address is listed above. Any use of the information contained herein in
any way (including, but not limited to, total or partial disclosure,
reproduction or dissemination) by persons other than the intended recipient(s)
is prohibited. If you receive this email in error, please notify the sender by
phone or email immediately and delete it.