[FFmpeg-devel] [PATCH] doc/developper: always use braces for statements

Nicolas George george at nsup.org
Wed Aug 7 14:57:44 EEST 2019


Moritz Barsnick (12019-08-07):
> On Wed, Aug 07, 2019 at 00:14:06 +0200, Alexander Strasser wrote:
> > Nicolas, changes to the coding style should be discussed and not
> > be tunneled through documentation patches. Though I don't think
> > the latter was the intention of the OP.
> 
> It was probably caused by different reviews:
> - "Please remove the brackets."
> - "Please add brackets."
> 
> I don't feel strongly about style rules being changed (though I do
> prefer one of the two), but it should be consistent and documented.

I think it is one of the cases that are best left to the discretion of
whoever writes the code, or whoever maintains it if they have a strong
opinion about it: there are more case-by-case factors than general
arguments.

And the communication about it was clumsy, but let us not dwell on it.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190807/334bada6/attachment.sig>


More information about the ffmpeg-devel mailing list